RavenclawDev: changes in request.pm cause no output in TTY

[Svetlana Stenchikova]

I found the bug!

I had:
"what_can_i_say" =>  return  "you can say something like 'four pm'"

"return" is illegal here. Strangely nothing crashed, which made it hard to
track the bug.

Thank you for your answers.

Svetlana

On 10/11/06, Svetlana Stenchikova <svetastenchikova at gmail.com> wrote:
>
> Thanks Antoine,
>
> You are correct:
> < indicates old
> > indicates new
>
> If you are refering to line 64 of the file that i sent, it is "< old"
> line.
> I will try to look for the missing ","
>
> Svetlana
>
> On 10/11/06, Antoine Raux <antoine at cs.cmu.edu> wrote:
> >
> >  Hi Svetlana,
> >
> >
> >
> > I'm not sure what is the direction of the diff but if < indicate the old
> > and > indicate the new (non-working) version, you seem to be missing a comma
> > at the end of line 64 (first block of the diff file). Generally speaking,
> > missing commas (between a => b elements of the hash) are a common source of
> > NLG crashes… You might wanna check that.
> >
> >
> >
> > antoine
> >
> >
> >  ------------------------------
> >
> > *From:* ravenclaw-developers-bounces at LOGANBERRY.srv.cs.cmu.edu [mailto:
> > ravenclaw-developers-bounces at LOGANBERRY.srv.cs.cmu.edu] * On Behalf Of *Svetlana
> > Stenchikova
> > *Sent:* Wednesday, October 11, 2006 12:25 PM
> > *To:* Thomas K Harris
> > *Cc:* ravenclaw-developers at cs.cmu.edu
> > *Subject:* Re: RavenclawDev: changes in request.pm cause no output in
> > TTY
> >
> >
> >
> > Thanks Thomas, I tried adding 1; it still did not work. The old version
> > of Request.pm did not have a 1; either.
> >
> > Attaching the diff. Don't worry about it if it is not clear right away,
> > then I just need to add changes one by one.
> >
> > thank you,
> > Svetlana
> >
> >  On 10/11/06, *Thomas K Harris* <tkharris at cs.cmu.edu> wrote:
> >
> > There's one off-the-wall possibility. I think that pm files themselves
> > have to evaluate to "true". It's usually done by putting a
> >
> >
> >
> > 1;
> >
> >
> >
> > at the end of the file which perhaps you elided. But that's just a wild
> > guess. Can you send a diff?
> >
> >
> >
> > -Thomas
> >
> >
> >   ------------------------------
> >
> > *From:* ravenclaw-developers-bounces at LOGANBERRY.srv.cs.cmu.edu [mailto:
> > ravenclaw-developers-bounces at LOGANBERRY.srv.cs.cmu.edu] * On Behalf Of *Svetlana
> > Stenchikova
> > *Sent:* Wednesday, October 11, 2006 12:00 PM
> > *To:* ravenclaw-developers at cs.cmu.edu
> > *Subject:* RavenclawDev: changes in request.pm cause no output in TTY
> >
> >
> >
> > Hi,
> >
> > I just made some  changes to request.pm and I stopped getting any output
> > in TTY after the "welcome" message.
> >
> > No servers crash, there are no errors that I can see. If I put he old
> > request.pm, it works again.
> >
> > Does anyone know what could possibly cause this? (I made many changes
> > and don't want to revert all the way to original..)
> >
> >
> > thank you,
> > Svetlana
> >
> >
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.srv.cs.cmu.edu/pipermail/ravenclaw-developers/attachments/20061011/1aead177/attachment-0001.html